Comments on: DataMatrix 0.5

By: Einar

Einar — Tue, 28 Oct 2008 19:25:48 +0000

I added your name anyway. 8P For the rest, I think I figured out some of the quirks, I’ll see about fixing them soon.

By: gioby

gioby — Mon, 27 Oct 2008 22:54:08 +0000

ah sorry, I forgot I already told you about doctest :).
For the copyrigth, don’t mind, since mine are very minor suggestions :)

By: gioby

gioby — Mon, 27 Oct 2008 22:51:18 +0000

Hi,
I left you some suggestions on github… just to try git :).

I think you should add doctests to your module, I find them very useful when you have to understand how to use a module.

Moreover, check the code for when you use a filehandler like StringIO instead of a file.

congratulations for the job :)

By: Einar

Einar — Wed, 22 Oct 2008 21:14:21 +0000

I went ahead and added you. Regarding doctest, tests were next on the queue but I didn’t have time to work on it. I’ll see what I can do in the next week.
BTW, if you do any modifications to the code, don’t forget to add your name as per copyright information.

By: giovanni

giovanni — Wed, 22 Oct 2008 21:02:54 +0000

Thank you, I’ll follow it on github.

Can you add some doctest string (see doctest module) to the code? I found them very useful to understand how to use it.
If you add me as a ‘collaborator’ (my username is dalloliogm), I’ll add you some suggestions (when I’ll have time)